Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature to execute user-defined command when repair is successfully finished #753

Merged
merged 10 commits into from
Dec 9, 2024
Merged

add feature to execute user-defined command when repair is successfully finished #753

merged 10 commits into from
Dec 9, 2024

Conversation

YZ775
Copy link
Contributor

@YZ775 YZ775 commented Jul 8, 2024 •
edited
Loading

In order to implement Non-Graceful Node Shutdwon, this PR adds feature to execute user-defined command when repair is successfully finished.

@YZ775 YZ775 self-assigned this Jul 8, 2024
@YZ775 YZ775 force-pushed the shutdown-before-retirement branch 5 times, most recently from 29e4a7a to 9a19c57 Compare July 8, 2024 05:18
@YZ775 YZ775 force-pushed the shutdown-before-retirement branch from b79aa51 to 421ea18 Compare October 23, 2024 00:55
@YZ775 YZ775 force-pushed the shutdown-before-retirement branch from b6f5e1f to 8835089 Compare October 24, 2024 07:36
@YZ775 YZ775 force-pushed the shutdown-before-retirement branch from 1ac57af to be6f34e Compare November 11, 2024 02:40
@YZ775 YZ775 force-pushed the shutdown-before-retirement branch from be6f34e to 5d66e2c Compare November 11, 2024 02:41
@YZ775 YZ775 force-pushed the shutdown-before-retirement branch from efe9908 to 3ee7ca7 Compare November 20, 2024 02:04
@YZ775 YZ775 force-pushed the shutdown-before-retirement branch from 3ee7ca7 to f847d21 Compare November 20, 2024 02:21
@YZ775 YZ775 changed the title Non-Graceful Node Shutdown before deleting k8s node add feature to execute user-defined command when repair is successfully finished Dec 5, 2024
@YZ775 YZ775 marked this pull request as ready for review December 5, 2024 01:20
@YZ775 YZ775 requested a review from morimoto-cybozu December 5, 2024 01:21
morimoto-cybozu
morimoto-cybozu requested changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature seems to work perfectly!

I added comments just for clarity.

op/repair_finish.go Outdated Show resolved Hide resolved
mtest/repair_test.go Outdated Show resolved Hide resolved
docs/cluster.md Outdated Show resolved Hide resolved
docs/repair.md Outdated Show resolved Hide resolved
docs/repair.md Outdated Show resolved Hide resolved
@YZ775 YZ775 requested a review from morimoto-cybozu December 9, 2024 02:07
@YZ775
Copy link
Contributor Author

YZ775 commented Dec 9, 2024

@morimoto-cybozu
Thank you for your review.
I fixed the code and document.

@YZ775 YZ775 merged commit b3f803d into main Dec 9, 2024
7 checks passed
@YZ775 YZ775 deleted the shutdown-before-retirement branch December 9, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morimoto-cybozu morimoto-cybozu morimoto-cybozu approved these changes

Assignees

@YZ775 YZ775

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YZ775 @morimoto-cybozu